[PATCH] D53688: [clangd] Add fallbackFlags initialization extension.

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

In https://reviews.llvm.org/D53688#1275586, @ilya-biryukov wrote:

> This feels like a configuration option that might be changed in the course of running clangd.
>  Are there any strong reasons to make it work only upon initialization? My guess is that it keeps the code simpler, but if we approached it purely from the UX perspective, changing it while running clangd seems to make sense. WDYT?


It's hard to reason about UX outside of concrete tools - the only use I know of (atom-ide-cpp) never needs to change it, and I'm having a hard time imagining when you'd want to change this, but still have it global to clangd. (I can imagine it being scoped to a subtree a la compile commands, but that's a whole different thing..)

And yes, there are significant implementation concerns with making it mutable: ultimately we're going to want to have a CDB -> clangd compile command invalidation mechanism that can drive reindexing, reloading diagnostics etc. If the fallback command is mutable, such a mechanism needs to handle wildcards (or accept that this is a case it will get wrong, there are others).


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53688