[PATCH] D53666: [Tests] Updated tests for D53342

Dávid Bolvanský via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 24 13:15:57 PDT 2018


xbolva00 added inline comments.


================
Comment at: test/CodeGenOpenCL/amdgpu-nullptr.cl:513
 // CHECK-LABEL: test_memset_private
-// CHECK: call void @llvm.memset.p5i8.i64(i8 addrspace(5)* align 8 {{.*}}, i8 0, i64 40, i1 false)
+// CHECK: call void @llvm.memset.p5i8.i64(i8 addrspace(5)* nonnull align 8 {{.*}}, i8 0, i64 40, i1 false)
 void test_memset_private(private StructTy3 *ptr) {
----------------
efriedma wrote:
> This shouldn't change.  "null" pointers are potentially valid in non-zero address-spaces.  (Sorry, I should have spotted this sooner.)
Thanks, I will fix this case.


Repository:
  rC Clang

https://reviews.llvm.org/D53666





More information about the cfe-commits mailing list