[PATCH] D53339: [clang-tidy] Add the abseil-duration-factory-float check

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 24 08:45:01 PDT 2018


JonasToth added inline comments.


================
Comment at: clang-tidy/abseil/DurationFactoryFloatCheck.cpp:84
+
+  // Check for floats without fractional components
+  if (const auto *LitFloat =
----------------
alexfh wrote:
> JonasToth wrote:
> > missing full stop
> Clang-tidy (and clang) diagnostics don't end with a period. This one doesn't need to be special in this regard. Same below.
I believe that was related to a comment to make it a full sentence with grammar and so on, AFAIK these are supposed to be correct.
The diagnostic message itself not, I did not intend to include it.


https://reviews.llvm.org/D53339





More information about the cfe-commits mailing list