[PATCH] D53192: [clangd] Do not query index for new name completions.

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 24 08:26:05 PDT 2018


kadircet added inline comments.


================
Comment at: unittests/clangd/CodeCompleteTests.cpp:2180
+  clangd::CodeCompleteOptions Opts;
+  Opts.AllScopes = true;
+  auto Results = completions(R"cpp(
----------------
sammccall wrote:
> Any need to actually enable this option, or just copied from above test?
> 
> (If not, no need to pass opts at all, it'll be defaulted).
Actually it was needed to check we don't add suggest items from cross namespaces, but I had an error in symbols name, changing that to start with "n" as well.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53192





More information about the cfe-commits mailing list