[PATCH] D53399: [clangd] Ensure that we reply to each call exactly once. NFC (I think!)

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 24 06:14:11 PDT 2018


ioeric added inline comments.


================
Comment at: clangd/ClangdLSPServer.cpp:112
+    SPAN_ATTACH(Tracer, "Params", Params);
+    ReplyOnce Reply(ID, Method, &Server, Tracer.Args);
     log("<-- {0}({1})", Method, ID);
----------------
Do we have guarantee that `Tracer.Args` outlives `Reply`?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53399





More information about the cfe-commits mailing list