[PATCH] D53571: [clangd] Don't show base class versions of members as completions.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 24 06:06:47 PDT 2018


ioeric added a comment.

> Keep required quailifier machinery around though, for cross-ns completion.

Do we have cross-ns completion in sema?



================
Comment at: clangd/CodeComplete.cpp:732
+      // Class members that are shadowed by subclasses are usually noise.
+      if (Result.Hidden && Result.Declaration &&
+          Result.Declaration->isCXXClassMember())
----------------
Are there hidden results that are neither declarations nor class members and do not require qualifier? 


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53571





More information about the cfe-commits mailing list