[PATCH] D53591: Support the __gnu__ scoped attribute token

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 23 18:30:41 PDT 2018


rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

Looks good.

We should provide some reserved-name way of naming clang attributes too, but I'm not sure what would be best (`__clang__` is a macro name). Maybe `_Clang`? (And maybe we should detect an integer literal `1` as a scope specifier and check whether it was written as a macro `__clang__`, and provide a custom error suggesting using whatever other scope specifier we prefer.)


https://reviews.llvm.org/D53591





More information about the cfe-commits mailing list