[PATCH] D53618: [AArch64] [Windows] Emit unwind tables by default.

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 23 15:33:52 PDT 2018


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Yep, land it after the dependency.



================
Comment at: lib/Driver/ToolChains/MSVC.cpp:725-727
   // Emit unwind tables by default on Win64. All non-x86_32 Windows platforms
   // such as ARM and PPC actually require unwind tables, but LLVM doesn't know
   // how to generate them yet.
----------------
Maybe update the comment to say that Windows has required unwind tables for every new architecture since x86_32, but clang only asks LLVM to emit unwind tables for the ones that LLVM supports.


Repository:
  rC Clang

https://reviews.llvm.org/D53618





More information about the cfe-commits mailing list