[PATCH] D53547: NFC: Remove the ObjC1/ObjC2 distinction from clang (and related projects)

David Chisnall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 23 11:14:30 PDT 2018


theraven accepted this revision.
theraven added a comment.
This revision is now accepted and ready to land.

Looks good for me, and removing all of the code describing Objective-C 4 as ObjC1 makes me happy.



================
Comment at: clang-tools-extra/clang-tidy/google/AvoidThrowingObjCExceptionCheck.cpp:23
   // this check should only be applied to ObjC sources.
-  if (!getLangOpts().ObjC1 && !getLangOpts().ObjC2) {
+  if (!getLangOpts().ObjC) {
     return;
----------------
LLVM style wants to get rid of the braces here (and the next few instances of this).  Since you're touching this code, would you mind fixing that as well?


https://reviews.llvm.org/D53547





More information about the cfe-commits mailing list