[PATCH] D53501: [clang-query] Refactor Output settings to booleans

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 23 06:06:39 PDT 2018


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from minor commenting nits.



================
Comment at: clang-query/Query.h:17
 #include "llvm/ADT/Optional.h"
+
 #include <string>
----------------
Spurious newline, or did clang-format insert this?


================
Comment at: clang-query/Query.h:138
 
+// Implements the exclusive 'set output dump|diag|print' options
+struct SetExclusiveOutputQuery : Query {
----------------
Missing full-stop at the end of the comment.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53501





More information about the cfe-commits mailing list