[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

[Xing via Phabricator via cfe-commits]

Higuoxing added a comment.

In https://reviews.llvm.org/D47687#1266893, @vsapsai wrote:

> Sorry about the delay. The change seems to be correct but `ninja check-clang` reveals the test "Misc/caret-diags-macros.c" is failing. Can you please look into that?


Hi, It's because the expression is given in multiple lines and my `SuggestParentheses` cannot give proper fix-it hint. But I could give proper `ParenRange` in macros. Shall we reserve current `SuggestParentheses` and just give Parenrange hit in macros ? I have no idea about this ...

> Appreciate your contribution, Xing, and thanks for verifying your change with tests.

My pleasure :) Thanks for your review.


https://reviews.llvm.org/D47687