[PATCH] D52857: [clang-query] Add non-exclusive output API

Peter Collingbourne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 22 12:02:14 PDT 2018


pcc added a comment.

I'm not really involved in clang-query development these days, so this is more of a drive-by comment. It wasn't really obvious to me what the wording of the help text for `set enable-output` meant:

> Set whether to enable <feature> content non-exclusively.

I figured out from the name of the option and from reading the source code that it just means "Enable output in format <feature>." This seems confusing to me because I would expect `set foo bar` to set the value of a variable `foo` to `bar`, which doesn't match what this command does. What do you think about spelling it as something like `enable output <feature>`?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52857





More information about the cfe-commits mailing list