[PATCH] D53308: [Fixed Point Arithmetic] Fixed Point to Boolean Cast

[Bevin Hansson via Phabricator via cfe-commits]

ebevhan added inline comments.


================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2026
+    return EmitScalarConversion(Visit(E), E->getType(), DestTy,
+                                CE->getExprLoc());
 
----------------
rjmccall wrote:
> Why are you pushing these casts through `EmitScalarConversion` when the cast kind already tells you which operation you're doing?
It could be useful to enable EmitScalarConversion to handle any of the conversions so it can be used in other contexts than expanding a cast.


Repository:
  rC Clang

https://reviews.llvm.org/D53308