[PATCH] D53391: [clangd] Embed fixes as CodeAction, instead of clangd_fixes. Clean up serialization.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 18 08:18:03 PDT 2018


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: clangd/ClangdLSPServer.cpp:558
                 json::Object{
                     {"uri", URIForFile{File}},
+                    {"diagnostics", std::move(LSPDiagnostics)},
----------------
nit: we can reuse `URI` insteading of calling `URIForFile` again.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53391





More information about the cfe-commits mailing list