[PATCH] D53389: [clangd] Clear the semantic of RefSlab::size.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 18 03:42:54 PDT 2018


hokein added a comment.

In https://reviews.llvm.org/D53389#1268250, @sammccall wrote:

> Adding numRefs() and fixing occurrences makes sense.
>  However I think `size()` needs to stay - it's an important part of the "container" concept, and e.g. GTest relies on it.


OK, and I added a comment for this method to avoid future confusion.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53389





More information about the cfe-commits mailing list