[PATCH] D53374: [clangd] Names that are not spelled in source code are reserved.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 17 07:38:33 PDT 2018


ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.

These are often not expected to be used directly e.g.

  TEST_F(Fixture, X) {
    ^  // "Fixture_X_Test" expanded in the macro should be down ranked.
  }

Only doing this for sema for now, as such symbols are mostly coming from sema
e.g. gtest macros expanded in the main file. We could also add a similar field
for the index symbol.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53374

Files:
  clangd/AST.cpp
  clangd/AST.h
  clangd/Quality.cpp
  unittests/clangd/QualityTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53374.170006.patch
Type: text/x-patch
Size: 4882 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181017/093974c0/attachment.bin>


More information about the cfe-commits mailing list