[PATCH] D53274: [analyzer][NFC] Fix inconsistencies in AnalyzerOptions

Umann Kristóf via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 15 15:32:34 PDT 2018


Szelethus marked 2 inline comments as done.
Szelethus added inline comments.


================
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:354
 
+StringRef AnalyzerOptions::getOptionAsString(Optional<StringRef> &V,
+                                             StringRef Name,
----------------
george.karpenkov wrote:
> I'm slightly confused, where is this function called?
> Same for the function above?
Its used in D53277, but this addition belongs here more.

Granted, I should've refactored this file to demonstrate why I made this change, but in D53277 I literally delete everything, so I didn't bother.


https://reviews.llvm.org/D53274





More information about the cfe-commits mailing list