[clang-tools-extra] r344549 - [Fixed Point Arithmetic] Fix for clang-tools-extra warning

Leonard Chan via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 15 13:00:03 PDT 2018


Author: leonardchan
Date: Mon Oct 15 13:00:03 2018
New Revision: 344549

URL: http://llvm.org/viewvc/llvm-project?rev=344549&view=rev
Log:
[Fixed Point Arithmetic] Fix for clang-tools-extra warning

Fix for warnings generated on unhandled enum value `STK_FixedPoint`.

Differential Revision: https://reviews.llvm.org/D53299

Modified:
    clang-tools-extra/trunk/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp

Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp?rev=344549&r1=344548&r2=344549&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp (original)
+++ clang-tools-extra/trunk/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp Mon Oct 15 13:00:03 2018
@@ -60,46 +60,47 @@ static StringRef getValueOfValueInit(con
   case Type::STK_IntegralComplex:
     return getValueOfValueInit(
         InitType->getAs<ComplexType>()->getElementType());
+
   case Type::STK_FixedPoint:
     switch (InitType->getAs<BuiltinType>()->getKind()) {
-      case BuiltinType::ShortAccum:
-      case BuiltinType::SatShortAccum:
-        return "0.0hk";
-      case BuiltinType::Accum:
-      case BuiltinType::SatAccum:
-        return "0.0k";
-      case BuiltinType::LongAccum:
-      case BuiltinType::SatLongAccum:
-        return "0.0lk";
-      case BuiltinType::UShortAccum:
-      case BuiltinType::SatUShortAccum:
-        return "0.0uhk";
-      case BuiltinType::UAccum:
-      case BuiltinType::SatUAccum:
-        return "0.0uk";
-      case BuiltinType::ULongAccum:
-      case BuiltinType::SatULongAccum:
-        return "0.0ulk";
-      case BuiltinType::ShortFract:
-      case BuiltinType::SatShortFract:
-        return "0.0hr";
-      case BuiltinType::Fract:
-      case BuiltinType::SatFract:
-        return "0.0r";
-      case BuiltinType::LongFract:
-      case BuiltinType::SatLongFract:
-        return "0.0lr";
-      case BuiltinType::UShortFract:
-      case BuiltinType::SatUShortFract:
-        return "0.0uhr";
-      case BuiltinType::UFract:
-      case BuiltinType::SatUFract:
-        return "0.0ur";
-      case BuiltinType::ULongFract:
-      case BuiltinType::SatULongFract:
-        return "0.0ulr";
-      default:
-        llvm_unreachable("Unhandled fixed point BuiltinType");
+    case BuiltinType::ShortAccum:
+    case BuiltinType::SatShortAccum:
+      return "0.0hk";
+    case BuiltinType::Accum:
+    case BuiltinType::SatAccum:
+      return "0.0k";
+    case BuiltinType::LongAccum:
+    case BuiltinType::SatLongAccum:
+      return "0.0lk";
+    case BuiltinType::UShortAccum:
+    case BuiltinType::SatUShortAccum:
+      return "0.0uhk";
+    case BuiltinType::UAccum:
+    case BuiltinType::SatUAccum:
+      return "0.0uk";
+    case BuiltinType::ULongAccum:
+    case BuiltinType::SatULongAccum:
+      return "0.0ulk";
+    case BuiltinType::ShortFract:
+    case BuiltinType::SatShortFract:
+      return "0.0hr";
+    case BuiltinType::Fract:
+    case BuiltinType::SatFract:
+      return "0.0r";
+    case BuiltinType::LongFract:
+    case BuiltinType::SatLongFract:
+      return "0.0lr";
+    case BuiltinType::UShortFract:
+    case BuiltinType::SatUShortFract:
+      return "0.0uhr";
+    case BuiltinType::UFract:
+    case BuiltinType::SatUFract:
+      return "0.0ur";
+    case BuiltinType::ULongFract:
+    case BuiltinType::SatULongFract:
+      return "0.0ulr";
+    default:
+      llvm_unreachable("Unhandled fixed point BuiltinType");
     }
   }
   llvm_unreachable("Invalid scalar type kind");




More information about the cfe-commits mailing list