[PATCH] D53274: [analyzer][NFC] Fix inconsistencies in AnalyzerOptions

[George Karpenkov via Phabricator via cfe-commits]

george.karpenkov added a comment.

I'm not sure why you could get away with removing those llvm_unreachable cases?



================
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:373
-      default:
-        llvm_unreachable("Invalid mode.");
       case UMK_Shallow:
----------------
Why?


================
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:418
-      default:
-        llvm_unreachable("Invalid mode.");
       case UMK_Shallow:
----------------
Why?


================
Comment at: lib/StaticAnalyzer/Core/CoreEngine.cpp:72
-    default:
-      llvm_unreachable("Unexpected case");
   }
----------------
Why?


https://reviews.llvm.org/D53274