[PATCH] D53292: [clangd] Add createIndex in dexp

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clangd/index/dex/dexp/Dexp.cpp:256
 
+std::unique_ptr<SymbolIndex> createIndex(llvm::StringRef Index) {
+  return loadIndex(Index, /*URISchemes=*/{}, /*UseDex=*/true);
----------------
createIndex seems a slightly odd name for this (as if writing new files or adding new data somehow): openIndex or so?


================
Comment at: clangd/index/dex/dexp/Dexp.cpp:273
   if (!Index) {
-    llvm::outs()
-        << "ERROR: Please provide a valid path to symbol collection file.\n";
+    llvm::outs() << "Failed to create an index.\n";
     return -1;
----------------
"to open the index"?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53292