[PATCH] D52750: [Diagnostics] Check for integer overflow in array size expressions

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added a comment.

Yeah, this looks better.

Though this really highlights that the "warn on undefined behavior" behavior of the constant evaluator should be orthogonal to the evaluation mode... we don't really need/want to evaluate past a side-effect or non-constant expression here.


https://reviews.llvm.org/D52750