[PATCH] D52771: [clang-tidy] Non-private member variables in classes (MISRA, CppCoreGuidelines, HICPP)

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 12 08:11:52 PDT 2018


JonasToth added inline comments.


================
Comment at: test/clang-tidy/misc-non-private-member-variables-in-classes.cpp:1
+// RUN: %check_clang_tidy -check-suffix=NONPRIVATE %s misc-non-private-member-variables-in-classes %t
+// RUN: %check_clang_tidy -check-suffix=NONPRIVATE %s misc-non-private-member-variables-in-classes %t -- -config='{CheckOptions: [{key: misc-non-private-member-variables-in-classes.IgnorePublicMemberVariables, value: 0}, {key: misc-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic, value: 0}]}' --
----------------
lebedev.ri wrote:
> zinovy.nis wrote:
> > JonasToth wrote:
> > > lebedev.ri wrote:
> > > > JonasToth wrote:
> > > > > I would prefer multiple test-files instead of mixing them all together.
> > > > Hmm, no. Then the tests will have to be duplicated in N files,
> > > > because i really do want to see what each of these 4 configurations do on the *same* input.
> > > > 
> > > > It only looks ugly because the script only supports `-check-suffix=`,
> > > > and not `-check-suffixes=`, which would significantly cut down on check-lines.
> > > Ok, if you prefer this.
> > Not an issue anymore. You can use `-check-suffixes` since now.
> Yay, look at this beauty :)
[[ https://i.pinimg.com/736x/ef/16/be/ef16bea67542d3628e95a307114d2be8--gaslighting-trump-tower.jpg | ;) ]]


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52771





More information about the cfe-commits mailing list