[PATCH] D53187: [clang-tidy] Optimize query in bugprone-exception-escape

[Balogh, Ádám via Phabricator via cfe-commits]

baloghadamsoftware added a comment.

In https://reviews.llvm.org/D53187#1263323, @JonasToth wrote:

> In https://reviews.llvm.org/D53187#1263294, @baloghadamsoftware wrote:
>
> > I think that with this optimization it is not so expensive anymore. I do not think it was an endless loop in the bugreport but it was insufferable execution time. Maybe we could speed it up a little more by changing it totally to a width-first CFG visitor. Then we could apply your solution as well (not removing visited function from the call stack) so the algorithm would visit every called function (for every function that should not throw) only once along the shortest path. This would not introduce new false positives neither would it lose true positives.
>
>
> In the debugging if have seen some functions analyzed thousands of times so I think this would really make a difference. Caching the result might work too?


Thousands? After the query optimization the max was 173, and that only for a single function. The next number was 64.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53187