[PATCH] D53170: [clang-doc] Switch to default to all-TUs executor

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 11 14:36:56 PDT 2018


Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:205
+                       llvm::cl::OptionCategory &Category) {
+  auto OptionsParser =
+      CommonOptionsParser::create(argc, argv, Category, llvm::cl::ZeroOrMore);
----------------
Please don't use auto when type is not spelled in same statement.


================
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:209
+    return OptionsParser.takeError();
+  for (auto I = ToolExecutorPluginRegistry::begin(),
+            E = ToolExecutorPluginRegistry::end();
----------------
Please use range loop.


https://reviews.llvm.org/D53170





More information about the cfe-commits mailing list