[PATCH] D53052: [AST] Use -fvisibility value when ignoring -fv-i-h* inline static locals

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 11 01:01:06 PDT 2018


hans added a comment.

In https://reviews.llvm.org/D53052#1261158, @rnk wrote:

> This is rewritten enough that you might want to re-review it, but I'm going to push it today so we don't have to wait another day/night cycle for the fix.


Looks good to me. It's hard to follow the logic, but the testing seems pretty comprehensive now. It's a lot like the dll attributes in that way :-)


Repository:
  rC Clang

https://reviews.llvm.org/D53052





More information about the cfe-commits mailing list