[clang-tools-extra] r280840 - Add a clang-tidy visual studio extension.

[Aaron Ballman via cfe-commits]

On Wed, Oct 10, 2018 at 4:54 PM Zachary Turner <zturner at google.com> wrote:
>
> Honestly I hadn’t thought about this ever since the patch. Out of curiosity, have you tried the clang power tools extension? I think it’s more actively maintained and at this point probably even is good enough that this one could just go away

I've not tried either, truth be told. :-D This came up in GrammaTech
while I was reviewing someone's clang-tidy check for upstreaming.
Given how much I review clang-tidy checks on trunk, the fact that I
hadn't heard of this file surprised me so I did some code archaeology
and here we are. I don't have a strong opinion on whether this has
been superseded or not, but I probably should know whether clang-tidy
check authors are required to maintain this or not.

Btw, I didn't see any bug reports about missing checks. In fact, the
only bug report I can find for clang-tidy-vs suggests it may not even
work. https://bugs.llvm.org/show_bug.cgi?id=34176

~Aaron

> On Wed, Oct 10, 2018 at 1:52 PM Aaron Ballman <aaron at aaronballman.com> wrote:
>>
>> On Wed, Sep 7, 2016 at 2:37 PM Zachary Turner via cfe-commits
>> <cfe-commits at lists.llvm.org> wrote:
>> >
>> > Author: zturner
>> > Date: Wed Sep  7 13:28:55 2016
>> > New Revision: 280840
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=280840&view=rev
>> > Log:
>> > Add a clang-tidy visual studio extension.
>> >
>> > For now this only adds the UI necessary to configure clang-tidy
>> > settings graphically, and it enables reading in and saving out
>> > of .clang-tidy files.  It does not actually run clang-tidy on
>> > any source files yet.
>>
>> Sorry to resurrect an old commit, but this commit added the following:
>>
>> Added: clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/Resources/ClangTidyChecks.yaml
>> URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/Resources/ClangTidyChecks.yaml?rev=280840&view=auto
>> ==============================================================================
>> --- clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/Resources/ClangTidyChecks.yaml
>> (added)
>> +++ clang-tools-extra/trunk/clang-tidy-vs/ClangTidy/Resources/ClangTidyChecks.yaml
>> Wed Sep  7 13:28:55 2016
>> @@ -0,0 +1,325 @@
>> +---
>> +Checks:
>> +   # This file should be updated when new checks are added, and
>> eventually we should
>> +   # generate this file automatically from the .rst files in clang-tidy.
>>
>> However, as best I can tell, this file is not reliably updated and is
>> currently *very* out of date (in fact, it's only been updated twice in
>> two years). You had mentioned in the review thread that you wanted to
>> think of a way to automate this from RST
>> (https://reviews.llvm.org/D23848?id=69168#inline-204743) -- any chance
>> you're still thinking on that and have a solution in mind? ;-)
>>
>> ~Aaron