[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 10 03:29:17 PDT 2018


kbobyrev added a comment.

In https://reviews.llvm.org/D51949#1257430, @JonasToth wrote:

> @kbobyrev is it ok for you if I stick with the `Optional<>` style in the check?


Yes, I think it's fine. Thank you very much for working on the patch, I am indeed very excited about this check.

Unfortunately, I won't be able to review the code in the upcoming few weeks as I caught a cold and I'm trying to get better before the LLVM Meeting, so if there is anyone else interested in reviewing proposed changes please feel free to jump in.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D51949





More information about the cfe-commits mailing list