[PATCH] D52610: [Esan] Port cache frag to FreeBSD

[David CARLIER via Phabricator via cfe-commits]

devnexen added inline comments.


================
Comment at: lib/CodeGen/BackendUtil.cpp:323
     Opts.ToolType = EfficiencySanitizerOptions::ESAN_CacheFrag;
-  else if (LangOpts.Sanitize.has(SanitizerKind::EfficiencyWorkingSet))
+  else if (T.getOS() == Triple::Linux &&
+    LangOpts.Sanitize.has(SanitizerKind::EfficiencyWorkingSet))
----------------
krytarowski wrote:
> devnexen wrote:
> > krytarowski wrote:
> > > Is it possible to port it to FreeBSD and skip some conditions in generic code?
> > Not for now, working-set hangs at init time on FreeBSD and unit tests had been disabled in the compiler-rt part.
> So can the support be extended in compiler-rt? I would find it more useful to handle featured sanitizer in the first place.
Not sure of the feasibility yet, let s say for now it s just a starting point.


Repository:
  rC Clang

https://reviews.llvm.org/D52610