[PATCH] D53042: [X86] Remove FeatureRTM from Skylake processor list

[Craig Topper via Phabricator via cfe-commits]

craig.topper requested changes to this revision.
craig.topper added a comment.
This revision now requires changes to proceed.

But there is definitely at least one test that needs to be updated. @thiagomacieira, can update them or would you like me to?



================
Comment at: lib/Basic/Targets/X86.cpp:169
     setFeatureEnabledImpl(Features, "mpx", true);
     if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX
       setFeatureEnabledImpl(Features, "sgx", true);
----------------
craig.topper wrote:
> lebedev.ri wrote:
> > > high-end desktop and server chips (I can't find any SKX without).
> > 
> > Are you sure you didn't want to move it into an else of this `if()` ?
> > This commit leaves it disabled for all processors, but can be re-enabled for specific builds with -mrtm.
> 
> So I think this was intended.
It's also consistent with gcc based on grepping for _RTM_ in their predefined macro output. https://godbolt.org/z/dtfrQU They don't infer it from -mcpu=skylake-avx512, but do when adding -mrtm


Repository:
  rC Clang

https://reviews.llvm.org/D53042