[PATCH] D53042: [X86] Remove FeatureRTM from Skylake processor list

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 9 14:13:00 PDT 2018


lebedev.ri added inline comments.


================
Comment at: lib/Basic/Targets/X86.cpp:169
     setFeatureEnabledImpl(Features, "mpx", true);
     if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX
       setFeatureEnabledImpl(Features, "sgx", true);
----------------
> high-end desktop and server chips (I can't find any SKX without).

Are you sure you didn't want to move it into an else of this `if()` ?


Repository:
  rC Clang

https://reviews.llvm.org/D53042





More information about the cfe-commits mailing list