[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 9 09:18:10 PDT 2018


Anastasia added a comment.

In https://reviews.llvm.org/D51402#1252619, @sidorovd wrote:

> @Anastasia , since there is a problem I described, wouldn't you mind if I stay with the first iteration of the patch (adding the extension to OpenCLExtensions.def) and after we'll investigate what is wrong with -cl-ext approach?


I would prefer not to add it to Clang directly unless absolutely necessary. I think it's ok to add this in the header for now as is, but then investigate how we can add an architecture guard later. Please, could you just move the testing into `test/Headers/opencl-c-header.cl`, because `test/SemaOpenCL/extension-version.cl` is for Clang built in extensions.


https://reviews.llvm.org/D51402





More information about the cfe-commits mailing list