[PATCH] D52742: [analyzer][PlistMacroExpansion] Part 1.: New expand-macros flag

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added inline comments.


================
Comment at: test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:6
+ <key>clang_version</key>
+<string>clang version 8.0.0 (http://mainstream.inf.elte.hu/Szelethus/clang 85a6dda64587a5a18482f091cbcf020fbd3ec1dd) (https://github.com/llvm-mirror/llvm 1ffbf26a1a0a190d69327af875a3337b74a2ce82)</string>
+ <key>diagnostics</key>
----------------
Szelethus wrote:
> whisperity wrote:
> > You are diffing against a hardcoded output file which contains //a git hash//! Won't this break at the next commit?!
> I'm actually using `%diff_plist`!
> ```
> // Check the actual plist output.
> //   RUN: cat %t.plist | %diff_plist \
> //   RUN:   %S/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist
> ```
> Here's the patch that implemented it (should jump to the config file): D52036#change-mOw5EmE2OiVA
Even if it will not break the build I would prefer to remove the non-official fork/mirror links from the test file.


https://reviews.llvm.org/D52742