[PATCH] D52998: [benchmark] Disable exceptions in Microsoft STL

Zachary Turner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 8 15:15:43 PDT 2018


zturner added a comment.

It's not enough to just set `_HAS_EXCEPTIONS=1`, it has to match whatever the value of `/EH` is passed to the compiler.  So if we need to be able to throw catch exceptions, then you should pass `/EHsc` and not touch `_HAS_EXCEPTIONS` (technically you could set it to 1 but that's the default).  And if we don't need to be able to throw or catch exceptions, then we pass `/EHs-c-` (which is what we do today) and also set `_HAS_EXCEPTIONS=0`.  But the two should agree with each other.


https://reviews.llvm.org/D52998





More information about the cfe-commits mailing list