[PATCH] D46441: [clang][CodeGenCXX] Noalias attr for 'this' parameter

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 8 10:32:54 PDT 2018


rjmccall accepted this revision.
rjmccall added a comment.

LGTM.



================
Comment at: lib/CodeGen/CGCall.cpp:2049
+        // from the constructor’s this pointer, the value of the object or
+        // subobject thus obtained is unspecified.
+        unsigned ThisIRArg, NumIRArgs;
----------------
rjmccall wrote:
> You probably ought to add here that we're treating this as undefined behavior and have recommended the standard be changed.
Thanks, looks good.


https://reviews.llvm.org/D46441





More information about the cfe-commits mailing list