[PATCH] D52984: [analyzer] Checker reviewer's checklist

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun updated this revision to Diff 168664.
xazax.hun added a comment.

- Added the ideas from Kristof.


https://reviews.llvm.org/D52984

Files:
  www/analyzer/checker_dev_manual.html


Index: www/analyzer/checker_dev_manual.html
===================================================================
--- www/analyzer/checker_dev_manual.html
+++ www/analyzer/checker_dev_manual.html
@@ -705,6 +705,20 @@
 <li>The list of <a href="implicit_checks.html">Implicit Checkers</a></li>
 </ul>
 
+<h2 id=links>Checker Reviewer Checklist</h2>
+<ul>
+<li>Is there unintended branching in the exploded graph?</li>
+<li>Are there unintended sinks?</li>
+<li>Produced reports are easy to understand? Do we need bug visitors? Is there a way to suppress false positives?</li>
+<li>Have the checker been run on large projects?</li>
+<li>Did we update the list of available checks on the homepage?</li>
+<li>Are GDM structures properly cleaned up?</li>
+<li>Escaping into unkown functions is properly handled (if applicable)?</li>
+<li>Is -analyzer-checker=core included in all RUN: lines?</li>
+<li>Is the description in Checkers.td clear to the users?</li>
+<li>Are Checkers.td and the CMakeLists entry alphabetically ordered?</li>
+</ul>
+
 </div>
 </div>
 </body>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52984.168664.patch
Type: text/x-patch
Size: 1062 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181008/42f4cc59/attachment-0001.bin>