[PATCH] D52398: Thread safety analysis: Unwrap __builtin_expect in getTrylockCallExpr

Jordan Rupprecht via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 5 18:57:34 PDT 2018


rupprecht added a comment.

In https://reviews.llvm.org/D52398#1257133, @aaronpuchert wrote:

> In https://reviews.llvm.org/D52398#1257092, @rupprecht wrote:
>
> > I patched the proposed fix-forward and it seems to have things building again. Is there an ETA on landing that? If it's going to take a bit, is there any chance we could revert this patch until then?
>
>
> The fix was just committed (https://reviews.llvm.org/rC343902). Generally I'm for reverting if there are functional deficiencies, but here it's more that an unrelated issue was accidentally uncovered by this patch.


Ah, I thought it was an issue with this patch. Clearly I shouldn't pretend to understand thread analysis :)
Thanks for the fix!


Repository:
  rL LLVM

https://reviews.llvm.org/D52398





More information about the cfe-commits mailing list