[PATCH] D46441: [clang][CodeGenCXX] Noalias attr for copy/move constructor arguments

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 5 10:15:44 PDT 2018


rjmccall added inline comments.


================
Comment at: lib/CodeGen/CGCall.cpp:1893
+
+    IsCtor = isa<CXXConstructorDecl>(TargetDecl);
   }
----------------
I feel like you should just use `TargetDecl && isa<CXXConstructorDecl>(TargetDecl)` below; it's more obvious.

Is there not an analogous rule for destructors?


Repository:
  rC Clang

https://reviews.llvm.org/D46441





More information about the cfe-commits mailing list