[PATCH] D51725: Allow un-setting the compilation database path

Simon Marchi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 4 12:37:20 PDT 2018


simark added a comment.

So I revisited this today.  In the end, restarting clangd in our IDE works well.  It should be merged anytime soon:

https://github.com/theia-ide/theia/pull/3017

But I am wondering what to do with the feature that allows clangd to change compilation database path using the `didChangeConfiguration` notification.  In my opinion, it's a bug that it's not possible to switch back to use no explicit compilation database path, so I'd still like to get this patch merged.  Or, if we decide this is really not useful, then it should be removed.  I don't think we should keep the feature in the current state, either we fix it or remove it.

Even if right now it's not very expensive to restart clangd, do you foresee a situation in the future where it could become more expensive?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D51725





More information about the cfe-commits mailing list