[PATCH] D52531: [clangd] clangd-indexer gathers refs and stores them in index files.

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

looks good.



================
Comment at: clangd/index/Serialization.cpp:301
+// A refs section has data grouped by Symbol. Each symbol has:
+//  - SymbolID: 20 bytes
+//  - NumRefs: varint
----------------
sammccall wrote:
> hokein wrote:
> > Looks like we can improve the size further, we are storing SymbolID twice (one in `symb` section), I think we could   optimize it by introducing a `symi` section or using `stri` section?
> Yes, there's a TODO on line 250. I opted not to do so in this patch, as it's a more invasive change and I wasn't sure about the exact representation.
> It should be straightforward to add later and bump the version.
SG.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52531