[PATCH] D52695: [clang][Parse] Diagnose useless null statements (PR39111)

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri updated this revision to Diff 168240.
lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.

Thank you for taking a look!

- Reworded the diag as suggested a little
- Do consume consequtive semis as one
  - Do still record each one of them in AST. I'm not sure if we want to do that, but else existing tests break.


Repository:
  rC Clang

https://reviews.llvm.org/D52695

Files:
  docs/ReleaseNotes.rst
  include/clang/Basic/DiagnosticGroups.td
  include/clang/Basic/DiagnosticParseKinds.td
  include/clang/Parse/Parser.h
  lib/Parse/ParseExprCXX.cpp
  lib/Parse/ParseStmt.cpp
  test/Parser/extra-semi-resulting-in-nullstmt-in-init-statement.cpp
  test/Parser/extra-semi-resulting-in-nullstmt.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52695.168240.patch
Type: text/x-patch
Size: 11949 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181004/34beace4/attachment-0001.bin>