[PATCH] D52838: [COFF, ARM64] Add __getReg intrinsic

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added subscribers: efriedma, peter.smith.
mstorsjo added a comment.

In https://reviews.llvm.org/D52838#1253998, @mgrang wrote:

> I have some questions about the behavior of getReg:
>
> __getReg ultimately invokes getRegisterByName in http://llvm.org/doxygen/AArch64ISelLowering_8cpp_source.html.
>
> You can __getReg only those registers which appear in the switch-case inside that function. Even then the logic there checks if the requested register is reserved. If not, then it makes the reg = 0 which results in "Invalid register name" error.
>
> I am not sure how this should be dealt with. Is it fine to add all regs (0-31) to the switch-case in getRegisterByName? And should the checks for isRegReserved be bypassed for COFF?


I don't really know about this one, I'll add a few more people who might be able to comment on it. @efriedma @peter.smith


Repository:
  rC Clang

https://reviews.llvm.org/D52838