[PATCH] D52819: Support checking out cte to 'extra' only as backward compatibility

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 3 04:30:03 PDT 2018


aaron.ballman added a comment.

Given the scope of what this changes (such as 3rd party configurations), I think that this requires a broader community discussion than what you'll get from this patch. I would suggest starting an [RFC] thread on cfe-commits and cfe-dev to see what people think of the idea.

Personally, I'm opposed to the idea. There is limited benefit compared to the number of scripts I will have to go update for out-of-tree builds where I'll suddenly be getting cmake warnings about a directory name that I've used without issue for years. If anything, I think the logic should be reversed so that we warn users who try to use "clang-tools-extra" as the directory name rather than "extra".


Repository:
  rC Clang

https://reviews.llvm.org/D52819





More information about the cfe-commits mailing list