[PATCH] D52782: [clang-tidy] Sequence statements with multiple parents correctly (PR39149)

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 2 11:51:37 PDT 2018


JonasToth added inline comments.


================
Comment at: clang-tidy/utils/ExprSequence.cpp:103
   for (const Stmt *Parent : getParentStmts(S, Context)) {
+    // For statements that have multiple parents, make sure we're using the
+    // parent that lies within the sub-tree under Root.
----------------
I find the first part of the comment unclear. Does this loop handle `for` only?


================
Comment at: test/clang-tidy/bugprone-use-after-move.cpp:1198
 
+// Null statements (and some other statements) in templates may be shared
+// between the uninstantiated and instantiated versions of the template and
----------------
Which other stmts? do they produce the same false positive?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52782





More information about the cfe-commits mailing list