[PATCH] D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 1 05:33:45 PDT 2018


JonasToth added inline comments.


================
Comment at: test/clang-tidy/performance-move-constructor-init.cpp:115-117
+  // CHECK-NOTES: 7:1: note: FIX-IT applied suggested code changes
+  // CHECK-NOTES: 113:28: note: FIX-IT applied suggested code changes
+  // CHECK-NOTES: 113:29: note: FIX-IT applied suggested code changes
----------------
alexfh wrote:
> This is an example of not very useful CHECK-NOTES patterns.  The corresponding notes are issued in Clang and there's not much value in testing them here. They also duplicate the CHECK-FIXES pattern below. Should the script filter these notes out, maybe?
I agree that they dont add any value.
I try to change the filtering regex to give a pass to `note: FIX-IT`


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52691





More information about the cfe-commits mailing list