[PATCH] D52339: Support enums with a fixed underlying type in all language modes

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In https://reviews.llvm.org/D52339#1249531, @rsmith wrote:

> In https://reviews.llvm.org/D52339#1249457, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D52339#1249432, @erik.pilkington wrote:
> >
> > > Ping! This doesn't really affect CUDA or OpenCL more than any change to the compiler, so I don't think it makes sense to block this until we hear from them.
> >
> >
> > It impacts them insomuch as they're standards and they may want to opt out of extensions for keeping code portable to other compilers.
>
>
> My view is that that's what `-pedantic` / `-pedantic-errors` are for. We want Clang to have a consistent user experience across languages, so if we're supporting fixed underlying types as an official Clang extension in languages that don't have it as a feature, that should apply everywhere it makes sense.


That sounds like a reasonable approach to me. I'll switch my LGTM to RLGTM (Really LGTM). :-)


Repository:
  rC Clang

https://reviews.llvm.org/D52339