[PATCH] D52443: Thread safety analysis: Examine constructor arguments

Delesley Hutchins via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 27 15:32:33 PDT 2018


delesley added inline comments.


================
Comment at: lib/Analysis/ThreadSafety.cpp:2046
   const CXXConstructorDecl *D = Exp->getConstructor();
   if (D && D->isCopyConstructor()) {
     const Expr* Source = Exp->getArg(0);
----------------
As a side note, we should probably special-case the move constructor too, with AK_Written.  That should be in a separate patch, though, and needs to be sequestered under -Wthread-safety-beta, which is complicated.   


Repository:
  rC Clang

https://reviews.llvm.org/D52443





More information about the cfe-commits mailing list