[PATCH] D52547: Tell whether file/folder for include completions.

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 27 05:43:59 PDT 2018


kadircet added a comment.

In https://reviews.llvm.org/D52547#1246701, @ilya-biryukov wrote:

> A drive-by comment.
>  Would it be cleaner to pass this information from clang? Relying on completion label seems shaky.


Actually I also wanted to do that at first, but then wasn't really sure whether we should introduce a new contextkind or not, because it is more about lsp and wasn't sure if it would be widely applicable to have a distinction between file/directory(folder) as a completion context kind.
WDYT @sammccall , would introducing a new completion context carry its weight?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52547





More information about the cfe-commits mailing list