[PATCH] D51686: [OpenMP] Improve search for libomptarget-nvptx

[Jonas Hahnfeld via Phabricator via cfe-commits]

Hahnfeld added inline comments.


================
Comment at: lib/Driver/ToolChains/Cuda.cpp:665
 
+    // Add path to lib / lib64 folder.
+    SmallString<256> DefaultLibPath =
----------------
Hahnfeld wrote:
> ABataev wrote:
> > You're changing the order of the lookup for the paths. Is this intended? If so, you need the test for this.
> Yes, that's explained in the summary.
> 
> I'll try to see if there is a way to test this, even if we can't expect libomptarget-nvptx to be built together with Clang. At the moment I think only `LIBRARY_PATH` is tested, I'm adding some for the new `--libomptarget-nvptx-path`.
After some thoughts it seems impossible to reliably test this code path because the user can set `CLANG_LIBDIR_SUFFIX`.


https://reviews.llvm.org/D51686