[PATCH] D52465: [clangd] Extract mapper logic from clangd-indexer into a library.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 25 11:38:14 PDT 2018


sammccall marked 3 inline comments as done.
sammccall added a comment.

Thanks!
Will land in a day or two, we maintain some out-of-tree mapreduce patches to this file that I need to turn into a real fork.



================
Comment at: clangd/index/IndexAction.h:24
+//   - references are always counted
+//   - (all) references ane provided if RefsCallback is non-null
+//   - the symbol origin is always Static
----------------
kadircet wrote:
> s/ane/are/
> 
> What is RefsCallback?
Oops, I considered adding refs collection in this patch and then decided against it (add later instead)


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52465





More information about the cfe-commits mailing list