[PATCH] D52266: [clang-cl] Provide separate flags for all the /O variants

[Hans Wennborg via Phabricator via cfe-commits]

hans added a comment.

In https://reviews.llvm.org/D52266#1244733, @thakis wrote:

> > Actually, trying this out with MSVC, I don't see any __chkstk calls with /https://reviews.llvm.org/owners/package/1/, or with eg. /Gs1 for that matter:
>
> (.guess the bug should also cover to eventually not alias /Gs to /Gs0 and/or /Gs to -mstack-probe-size either if cl doesn't do that)


Filed https://bugs.llvm.org/show_bug.cgi?id=39074



================
Comment at: include/clang/Driver/CLCompatOptions.td:118
+def _SLASH_O : CLJoined<"O">,
+  HelpText<"Set many /O flags at once; e.g. '/O2y-' is the same as '/O2 /y-'">,
+  MetaVarName<"<flags>">;
----------------
thakis wrote:
> very nit: Maybe s/many/several/ or s/many/multiple/
Ah, you noticed that. I switched to many for the 80-col limit. But multiple is better, so let's use that.


https://reviews.llvm.org/D52266